https://olddev.minetest.org/index.php?action=history&feed=atom&title=Merging_core_pull_requests_to_upstream 2026-04-15T02:53:06Z Revision history for this page on the wiki MediaWiki 1.38.7 https://olddev.minetest.org/index.php?title=Merging_core_pull_requests_to_upstream&diff=111&oldid=prev 2022-09-24T16:08:05Z

<p></p> <p><b>New page</b></p><div>This page contains '''technical guidelines''' for core developers when deciding whether to merge a pull request.<br /> <br /> For determining who is allowed to do what, see [[Organisation]].<br /> <br /> For guidelines and rules on Git and Github, see [[Git Guidelines]].<br /> <br /> Also see:<br /> * https://github.com/minetest/minetest/blob/master/.github/CONTRIBUTING.md<br /> * https://github.com/minetest/minetest/blob/master/doc/direction.md<br /> <br /> == Requirements ==<br /> <br /> There are five major requirements that each pull request must fullfill in order to be mergeable to upstream Minetest.<br /> <br /> # It should follow a roadmap in some way, to make sure it fits the whole picture of the project. Different roadmaps and project guidance is managed in https://github.com/minetest/minetest/blob/master/doc/direction.md. A core dev can decide to review and merge something that doesn't follow direction.md if they consider it to be beneficial to the project.<br /> # It must work in the first place. Compile it and test it in game, or write mod code that uses it.<br /> # The code style must be correct. http://dev.minetest.net/Code_style_guidelines<br /> # The internal interfaces of the code must be good, and it should be reasonably optimized, depending on how often the code is called.<br /> # The protocols and formats that it uses must be well designed, including the required compatibility in the part in question. On-disk formats are extremely important to get right. Modding API concerns are split between this and req2. This is about knowing the engine's design along with its pitfalls.<br /> <br /> ...which can be checked by:<br /> <br /> # Anyone.<br /> # Anyone, or at least any modder.<br /> # Those with a bit of general C++ and Lua knowledge.<br /> # Those with a lot of general C++ and Lua knowledge.<br /> # Those who have studied the file formats, the protocol and the Lua API, and know how version compatibility can be reliably done.<br /> <br /> == How can this help? ==<br /> <br /> I (celeron55) am interested in seeing whether we could end up in a situation<br /> where pull requests would get comments like &quot;req 1, 2 and 3 checked.&quot;, after which<br /> someone could do the rest and ultimately anyone could merge it based on these<br /> simple comments, after each of the five requirements have been checked.<br /> [[Category:Git]]</div>

>Celeron55